[receiver/kubeletstats][internal/kubelet] Fix tls config for service account auth #27070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Sep 22, 2023
TylerHelmuth
approved these changes
Sep 22, 2023
jinja2
force-pushed
the
kubeletclient-tls
branch
from
270436a to
bb667c0
Compare
TylerHelmuth
added
the
ready to merge
6 tasks
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…account auth (open-telemetry#27070) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Fix to use the `insecure_skip_verify` config in http client when connecting with kubelet in service account auth mode. **Link to tracking Issue:** [26319](open-telemetry#26319) **Testing:** <Describe what testing was performed and which tests were added.> Unit tests added, e2e test updated **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix to use the
insecure_skip_verifyconfig in http client when connecting with kubelet in service account auth mode.Link to tracking Issue: 26319
Testing:
Unit tests added, e2e test updated
Documentation: